Skip to content

Define CONNECT and OPTIONS in term of target URIs#352

Merged
royfielding merged 9 commits intomasterfrom
mnot-340
May 25, 2020
Merged

Define CONNECT and OPTIONS in term of target URIs#352
royfielding merged 9 commits intomasterfrom
mnot-340

Conversation

@mnot
Copy link
Copy Markdown
Member

@mnot mnot commented Mar 23, 2020

Fixes #340

@mnot mnot requested review from reschke and royfielding March 23, 2020 03:54
Copy link
Copy Markdown
Member

@royfielding royfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. Why are we reaching over backwards to call the request target a URI in these two cases where it is clearly not a URI? Why don't we just call it the request target? And then refer to it as the target URI when we are specifically referring to the target after it has been reconstituted as a URI.

@mnot mnot requested a review from royfielding April 27, 2020 04:20
@mnot
Copy link
Copy Markdown
Member Author

mnot commented Apr 27, 2020

PTAL.

Copy link
Copy Markdown
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with minor comments)

Co-authored-by: Mike Bishop <mbishop@evequefou.be>
@mnot
Copy link
Copy Markdown
Member Author

mnot commented May 5, 2020

@royfielding ?

@mnot
Copy link
Copy Markdown
Member Author

mnot commented May 18, 2020

Paging @royfielding

@mnot
Copy link
Copy Markdown
Member Author

mnot commented May 25, 2020

@royfielding can you please review? This is blocking other things.

@royfielding royfielding merged commit 3cf2240 into master May 25, 2020
@royfielding royfielding deleted the mnot-340 branch May 25, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

CONNECT, OPTIONS and request-target

4 participants