Use keyword argument for encoder in HTTP::FormData::Urlencoded#initialize for consistency

summera · summera · commit 3083334c759e · 2020-03-03T12:24:00.000-07:00
diff --git a/lib/http/form_data.rb b/lib/http/form_data.rb
@@ -47,7 +47,7 @@ def create(data, encoder: nil)
         if multipart?(data)
           Multipart.new(data)
         else
-          Urlencoded.new(data, encoder)
+          Urlencoded.new(data, encoder: encoder)
         end
       end
 
diff --git a/lib/http/form_data/urlencoded.rb b/lib/http/form_data/urlencoded.rb
@@ -63,7 +63,7 @@ def encoder
       end
 
       # @param [#to_h, Hash] data form data key-value Hash
-      def initialize(data, encoder = nil)
+      def initialize(data, encoder: nil)
         encoder ||= self.class.encoder
         @io = StringIO.new(encoder.call(FormData.ensure_hash(data)))
       end
diff --git a/spec/lib/http/form_data/urlencoded_spec.rb b/spec/lib/http/form_data/urlencoded_spec.rb
@@ -67,7 +67,7 @@
 
   context "with custom instance level encoder" do
     let(:encoder) { proc { |data| ::JSON.dump(data) } }
-    subject(:form_data) { HTTP::FormData::Urlencoded.new(data, encoder) }
+    subject(:form_data) { HTTP::FormData::Urlencoded.new(data, encoder: encoder) }
 
     it "uses encoder passed to initializer" do
       expect(form_data.to_s).to eq('{"foo[bar]":"test"}')
