fix: avoid panic when translating from hyperium#359
Merged
Fishrock123 merged 1 commit intohttp-rs:mainfrom Apr 27, 2021
Merged
Conversation
jbr
approved these changes
Apr 27, 2021
Member
jbr
left a comment
There was a problem hiding this comment.
Seems reasonable. It overwrote previously?
Member
Author
|
Err, actually, it theoretically overwrote previously but it actually just unconditionally panic-ed on any new header, since we're unwrapping the option from https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.insert ... I'll update the commit message to clarify that this really did not work before. |
172d856 to
c713ca4
Compare
Before it always paniced on new headers while trying to blankly unwrap the return of a hashmap insert. This makes it: a. no longer unwrap at all, which was incorrect, and b. use append for duplicates The opposite direction also uses hyperium's append, but (I think) this was written before that same functionality existed in http-types.
c713ca4 to
a222b1d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opposite direction also uses hyperium's append, but (I think) this was written before that same functionality existed in http-types.
This is somewhat important for my use and I intend to make a 2.11.1 release with this.