Update examples to use TryFrom<str> for Url implementation#294
Merged
yoshuawuyts merged 1 commit intohttp-rs:mainfrom Dec 18, 2020
Merged
Update examples to use TryFrom<str> for Url implementation#294yoshuawuyts merged 1 commit intohttp-rs:mainfrom
yoshuawuyts merged 1 commit intohttp-rs:mainfrom
Conversation
yoshuawuyts
approved these changes
Dec 18, 2020
Member
yoshuawuyts
left a comment
There was a problem hiding this comment.
Fantastic; thanks so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 first timer here, I hope this pr will fix #293 .
Please, let me know am missing something.