Conversation
Fishrock123
commented
Nov 5, 2020
- run on "main"
- really check everything
- move to non-deprecated --workspace from --all
- reduce unecessary actions-rs usage
- really clippy everything
- docs without deps
- run fmt-clippy-docs on beta
- run on "main" - really check everything - move to non-deprecated --workspace from --all - reduce unecessary actions-rs usage - really clippy everything - docs without deps
.github/workflows/ci.yaml
Outdated
| rustup toolchain install beta | ||
| rustup default beta |
There was a problem hiding this comment.
Can you say more why using beta makes sense here?
There was a problem hiding this comment.
Oh I guess it's just to get us off nightly?
There was a problem hiding this comment.
Yeah, nightly is currently missing rustfmt...
yoshuawuyts
left a comment
There was a problem hiding this comment.
No objections; just a question
e8e20d7 to
c4e45fe
Compare
|
Hmm, right we'd need to actually install clippy and rustfmt for beta. How about we just use stable? it's preinstalled on the github actions images and so it would be much faster. But maybe we want to be ahead of the game with beta? Not 100% sure. @yoshuawuyts What do you think? |
Avoids components sometimes not being available on nightly, and has less complexity than running beta.
c4e45fe to
932a676
Compare
|
Ok, this works now, and has less complexity to just run fmt-clippy-docs on stable, as discussed in zulip. Merging this |