Make statuscode from u16 in error#216
Merged
yoshuawuyts merged 2 commits intohttp-rs:masterfrom Aug 7, 2020
yusuke-ota:make_statuscode_from_u16_in_error
Merged
Make statuscode from u16 in error#216yoshuawuyts merged 2 commits intohttp-rs:masterfrom yusuke-ota:make_statuscode_from_u16_in_error
yoshuawuyts merged 2 commits intohttp-rs:masterfrom
yusuke-ota:make_statuscode_from_u16_in_error
Conversation
change status that Error::new and Error::from_str argument status: StatusCode -> status: S S: TryInto<StatusCode> S::Error: Debug
yoshuawuyts
approved these changes
Aug 7, 2020
Member
yoshuawuyts
left a comment
There was a problem hiding this comment.
A few nits; but this looks 💯 overall!
tests/error.rs
Outdated
| #[should_panic] | ||
| fn fail_test_u16_into_status_code_in_http_types_error_from_str() { | ||
| let _http_types_error = Error::from_str(1000, "Un Existed"); | ||
| } No newline at end of file |
Contributor
Author
|
Thanks for reviewing. Your suggestion commit at f26568c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
http-types::Error::new(u16, Error),http-types::Error::from_str(u16, &str)Description
Change
Error::new(StatusCode, impl Into<anyhow::Error>)toError::new(impl TryInto<StatusCode>, impl Into<anyhow::Error>).Maybe, new tests I added are needless.
Before this pull request merge, please tell me. I`ll remove them.
Motivation and Context
A Part of tide#649
This enable
Error::new(u16, error) like Response::new(u16).How Has This Been Tested?
Add tests.
But, maybe these tests are needless after marge.
Types of changes
Checklist: