HTCONDOR-3712 cmake should only set -DLINUX=1, not the full kernel#4500
Merged
timtheisen merged 1 commit intoMay 25, 2026
Merged
Conversation
version We don't use the kernl version, and it breaks repoduciility.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves build reproducibility by stopping CMake from embedding the host kernel version into the OS preprocessor definition (e.g., avoiding -DLINUX="LINUX_6.8.0-...") and instead defining only the OS macro as enabled (e.g., -DLINUX=1).
Changes:
- Replace the OS preprocessor definition from a kernel-version string to a simple numeric define (
1) in the CMake configuration step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version We don't use the kernl version, and it breaks repoduciility.
<Insert PR description here, and leave checklist below for code review.>
HTCondor Pull Request Checklist for internal reviewers
After the above