refactor: admin client#79
Merged
g1eny0ung merged 6 commits intohstreamdb:mainfrom Dec 12, 2023
g1eny0ung:refactor/admin-client
Merged
refactor: admin client#79g1eny0ung merged 6 commits intohstreamdb:mainfrom g1eny0ung:refactor/admin-client
g1eny0ung merged 6 commits intohstreamdb:mainfrom
g1eny0ung:refactor/admin-client
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 82.78% 83.54% +0.76%
==========================================
Files 40 43 +3
Lines 2474 2413 -61
==========================================
- Hits 2048 2016 -32
+ Misses 314 294 -20
+ Partials 112 103 -9 ☔ View full report in Codecov by Sentry. |
Rory-Z
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of #76. I divided some standalone changes to reduce the size of the original PR.
Changes
In the old implementation, we only specified some isolated admin commands like
BootstrapHServerorBootstrapHStore, etc. This does not apply to subsequent changes because if other admin commands are integrated into controllers, we need a public method to execute various commands to avoid rewriting tedious code.So this PR extracts two packages:
selectorandexecutor, one is for selecting k8s resources like pods, and one is for executing admin commands (some of them will execute in pods). Theinternal/adminwill use theexecutorto perform more specific tasks. Like bootstrapping hservers, as above said.