Skip to content

chore: move hserver constants into pkg#66

Merged
g1eny0ung merged 1 commit intohstreamdb:mainfrom
g1eny0ung:chore/hserver-constants
Nov 7, 2023
Merged

chore: move hserver constants into pkg#66
g1eny0ung merged 1 commit intohstreamdb:mainfrom
g1eny0ung:chore/hserver-constants

Conversation

@g1eny0ung
Copy link
Contributor

Move default HServer ports into pkg/constants for better management.

@g1eny0ung g1eny0ung requested a review from Rory-Z as a code owner November 6, 2023 10:03
@codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fdb13ba) 82.31% compared to head (86e735b) 82.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   82.31%   82.23%   -0.08%     
==========================================
  Files          38       38              
  Lines        2414     2415       +1     
==========================================
- Hits         1987     1986       -1     
- Misses        315      317       +2     
  Partials      112      112              
Files Coverage Δ
internal/admin/client.go 62.50% <100.00%> (ø)
internal/controller/add_console.go 76.86% <100.00%> (ø)
internal/controller/add_geteway.go 83.59% <100.00%> (ø)
internal/controller/add_hmeta.go 90.90% <100.00%> (ø)
internal/controller/add_services.go 65.62% <100.00%> (ø)
internal/controller/utils.go 91.79% <100.00%> (+0.06%) ⬆️
internal/controller/add_hserver.go 89.57% <81.25%> (-1.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g1eny0ung g1eny0ung merged commit e04b285 into hstreamdb:main Nov 7, 2023
@g1eny0ung g1eny0ung deleted the chore/hserver-constants branch November 7, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants