Skip to content

chore(connector): allow to set container resources#64

Merged
g1eny0ung merged 6 commits intohstreamdb:mainfrom
g1eny0ung:chore/connector-resources
Nov 1, 2023
Merged

chore(connector): allow to set container resources#64
g1eny0ung merged 6 commits intohstreamdb:mainfrom
g1eny0ung:chore/connector-resources

Conversation

@g1eny0ung
Copy link
Contributor

Close #61.

@g1eny0ung g1eny0ung requested a review from Rory-Z as a code owner October 31, 2023 07:00
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (eefa938) 83.02% compared to head (cefdeca) 82.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   83.02%   82.60%   -0.42%     
==========================================
  Files          38       38              
  Lines        2403     2414      +11     
==========================================
- Hits         1995     1994       -1     
- Misses        297      309      +12     
  Partials      111      111              
Files Coverage Δ
api/v1beta1/connector_types.go 100.00% <ø> (ø)
internal/controller/utils.go 91.72% <90.90%> (+0.06%) ⬆️
mock/connector.go 0.00% <0.00%> (-100.00%) ⬇️
internal/controller/connector_controller.go 79.60% <91.66%> (+5.43%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g1eny0ung g1eny0ung merged commit fdb13ba into hstreamdb:main Nov 1, 2023
@g1eny0ung g1eny0ung deleted the chore/connector-resources branch November 1, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connector: allow to set container resources

2 participants