chore(connector): allow to set image registry#63
Merged
g1eny0ung merged 1 commit intohstreamdb:mainfrom Oct 31, 2023
g1eny0ung:chore/connector-registry
Merged
chore(connector): allow to set image registry#63g1eny0ung merged 1 commit intohstreamdb:mainfrom g1eny0ung:chore/connector-registry
g1eny0ung merged 1 commit intohstreamdb:mainfrom
g1eny0ung:chore/connector-registry
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 82.77% 82.77% -0.01%
==========================================
Files 38 38
Lines 2398 2403 +5
==========================================
+ Hits 1985 1989 +4
- Misses 301 302 +1
Partials 112 112
☔ View full report in Codecov by Sentry. |
Collaborator
|
Looks good, and I think we should add depend image list in document, for user can download and repush them to user self registry. |
Rory-Z
approved these changes
Oct 31, 2023
Contributor
Author
Got it. I will create a new PR to handle this after the sink elasticsearch connector is stable in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #62.