Skip to content

refactor: upgrade to go/v4 plugin#58

Merged
Rory-Z merged 5 commits intohstreamdb:mainfrom
g1eny0ung:go/v4
Oct 17, 2023
Merged

refactor: upgrade to go/v4 plugin#58
Rory-Z merged 5 commits intohstreamdb:mainfrom
g1eny0ung:go/v4

Conversation

@g1eny0ung
Copy link
Contributor

@g1eny0ung g1eny0ung commented Oct 16, 2023

https://kubebuilder.io/plugins/go-v4-plugin

To adapt to the latest kubebuilder development, refer to https://kubebuilder.io/migration/migration_guide_gov3_to_gov4, I upgraded the project structure from go/v3 to go/v4. The main changes are below:

  • Upgrade go version to v1.20
  • Upgrade envtest k8s version to v1.28.0

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ae4391a) 84.15% compared to head (0a57350) 84.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files          31       31           
  Lines        2057     2057           
=======================================
  Hits         1731     1731           
- Misses        232      233    +1     
+ Partials       94       93    -1     
Files Coverage Δ
internal/controller/add_admin_server.go 85.88% <ø> (ø)
internal/controller/add_console.go 76.86% <ø> (ø)
internal/controller/add_geteway.go 88.28% <ø> (ø)
internal/controller/add_hmeta.go 90.90% <ø> (ø)
internal/controller/add_hserver.go 90.79% <ø> (ø)
internal/controller/add_hstore.go 92.35% <ø> (ø)
internal/controller/add_services.go 65.62% <ø> (ø)
internal/controller/bootstrap_hserver.go 81.81% <ø> (ø)
internal/controller/bootstrap_hstore.go 76.00% <ø> (ø)
internal/controller/hstreamdb_controller.go 100.00% <ø> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g1eny0ung g1eny0ung changed the title refactor: upgrade to go/v4 refactor: upgrade to go/v4 plugin Oct 17, 2023
@g1eny0ung g1eny0ung marked this pull request as ready for review October 17, 2023 02:22
@g1eny0ung g1eny0ung requested a review from Rory-Z as a code owner October 17, 2023 02:22
@Rory-Z Rory-Z merged commit 4fccd69 into hstreamdb:main Oct 17, 2023
@g1eny0ung g1eny0ung deleted the go/v4 branch October 17, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants