chore: more moderate readiness probes in hserver#52
Merged
Rory-Z merged 1 commit intohstreamdb:mainfrom Oct 10, 2023
g1eny0ung:chore/update-hserver-readiness-probe
Merged
chore: more moderate readiness probes in hserver#52Rory-Z merged 1 commit intohstreamdb:mainfrom g1eny0ung:chore/update-hserver-readiness-probe
Rory-Z merged 1 commit intohstreamdb:mainfrom
g1eny0ung:chore/update-hserver-readiness-probe
Conversation
Contributor
Author
|
/cc @YangKian |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 84.16% 84.42% +0.25%
==========================================
Files 31 31
Lines 2053 2054 +1
==========================================
+ Hits 1728 1734 +6
+ Misses 231 227 -4
+ Partials 94 93 -1
☔ View full report in Codecov by Sentry. |
Rory-Z
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I conducted a test using a 3-hserver cluster, and I discovered that almost all hservers experienced an average of 10 failed readiness checks. To address this issue, I updated the readiness probe with
InitialDelaySeconds: 10to reduce unnecessary checks because the server takes some time to bootstrap.I have also increased the
PeriodSecondsappropriately, and reducedFailureThresholdby half relatively.