Skip to content

feat: more better parse hserver args#42

Merged
Rory-Z merged 1 commit intohstreamdb:mainfrom
Rory-Z:feat/hserver-args
Jul 1, 2023
Merged

feat: more better parse hserver args#42
Rory-Z merged 1 commit intohstreamdb:mainfrom
Rory-Z:feat/hserver-args

Conversation

@Rory-Z
Copy link
Collaborator

@Rory-Z Rory-Z commented Jun 30, 2023

No description provided.

@Rory-Z Rory-Z requested a review from logo306142054 as a code owner June 30, 2023 09:28
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: -0.24 ⚠️

Comparison is base (ecced7f) 84.10% compared to head (9f15856) 83.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   84.10%   83.86%   -0.24%     
==========================================
  Files          31       31              
  Lines        2063     2070       +7     
==========================================
+ Hits         1735     1736       +1     
- Misses        235      239       +4     
- Partials       93       95       +2     
Impacted Files Coverage Δ
controllers/add_hserver.go 88.88% <91.89%> (-1.74%) ⬇️
mock/default_cr.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Rory-Z Rory-Z force-pushed the feat/hserver-args branch from e50a63e to cfb2f66 Compare June 30, 2023 09:58
@Rory-Z Rory-Z force-pushed the feat/hserver-args branch from cfb2f66 to 9f15856 Compare July 1, 2023 08:12
@Rory-Z Rory-Z merged commit ef2a104 into hstreamdb:main Jul 1, 2023
@Rory-Z Rory-Z deleted the feat/hserver-args branch July 1, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant