Skip to content

feat: add conditions for HStreamDB#31

Merged
Rory-Z merged 1 commit intohstreamdb:mainfrom
Rory-Z:feat/add-conditions
May 17, 2023
Merged

feat: add conditions for HStreamDB#31
Rory-Z merged 1 commit intohstreamdb:mainfrom
Rory-Z:feat/add-conditions

Conversation

@Rory-Z
Copy link
Collaborator

@Rory-Z Rory-Z commented May 15, 2023

No description provided.

@Rory-Z Rory-Z requested a review from logo306142054 as a code owner May 15, 2023 08:49
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 70.17% and project coverage change: -0.67 ⚠️

Comparison is base (6c439a0) 86.79% compared to head (682d2c4) 86.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   86.79%   86.13%   -0.67%     
==========================================
  Files          23       24       +1     
  Lines        1515     1608      +93     
==========================================
+ Hits         1315     1385      +70     
- Misses        140      163      +23     
  Partials       60       60              
Impacted Files Coverage Δ
api/v1alpha2/condition_type.go 0.00% <0.00%> (ø)
api/v1alpha2/hstreamdb_types.go 25.00% <ø> (ø)
controllers/bootstrap_hserver.go 72.00% <ø> (-16.00%) ⬇️
controllers/bootstrap_hstore.go 70.42% <ø> (-4.23%) ⬇️
controllers/check_rqlite_status.go 82.35% <ø> (ø)
internal/pod_set_helper.go 100.00% <ø> (ø)
internal/service_helper.go 100.00% <ø> (ø)
controllers/update_status.go 86.81% <88.09%> (+36.81%) ⬆️
controllers/hstreamdb_controller.go 91.22% <100.00%> (+0.66%) ⬆️
internal/pod_helper.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Rory-Z Rory-Z force-pushed the feat/add-conditions branch 6 times, most recently from 0bc0d97 to 799110f Compare May 15, 2023 10:08
@Rory-Z Rory-Z force-pushed the feat/add-conditions branch from 799110f to b522a5f Compare May 16, 2023 07:00
@Rory-Z Rory-Z requested a review from logo306142054 May 16, 2023 07:00
Signed-off-by: Rory Z <rory-z@outlook.com>
@Rory-Z Rory-Z force-pushed the feat/add-conditions branch from b522a5f to 682d2c4 Compare May 16, 2023 07:02
@Rory-Z Rory-Z merged commit 23c6b5b into hstreamdb:main May 17, 2023
@Rory-Z Rory-Z deleted the feat/add-conditions branch May 17, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants