Skip to content

refactor: the flagSet.Parse does't delete '-' or '--' again#29

Merged
Rory-Z merged 1 commit intohstreamdb:mainfrom
Rory-Z:style/change-falgset
May 18, 2023
Merged

refactor: the flagSet.Parse does't delete '-' or '--' again#29
Rory-Z merged 1 commit intohstreamdb:mainfrom
Rory-Z:style/change-falgset

Conversation

@Rory-Z
Copy link
Collaborator

@Rory-Z Rory-Z commented May 11, 2023

and refactor utils.extendEnvs utils.extendArgs utils.extendPorts

@Rory-Z Rory-Z requested a review from logo306142054 as a code owner May 11, 2023 14:25
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 93.69% and project coverage change: -0.29 ⚠️

Comparison is base (23c6b5b) 85.03% compared to head (aef87ff) 84.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   85.03%   84.75%   -0.29%     
==========================================
  Files          30       30              
  Lines        1918     1889      -29     
==========================================
- Hits         1631     1601      -30     
  Misses        207      207              
- Partials       80       81       +1     
Impacted Files Coverage Δ
controllers/update_config_map.go 85.54% <ø> (ø)
controllers/utils.go 91.66% <90.14%> (-3.34%) ⬇️
controllers/add_admin_server.go 85.88% <100.00%> (-0.79%) ⬇️
controllers/add_geteway.go 88.28% <100.00%> (-0.61%) ⬇️
controllers/add_hmeta.go 90.97% <100.00%> (-0.39%) ⬇️
controllers/add_hserver.go 90.47% <100.00%> (-0.37%) ⬇️
controllers/add_hstore.go 92.40% <100.00%> (-0.15%) ⬇️
controllers/add_services.go 65.62% <100.00%> (+0.24%) ⬆️
internal/flagset.go 93.54% <100.00%> (+5.14%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Rory-Z Rory-Z force-pushed the style/change-falgset branch 2 times, most recently from 65b8730 to 48644ec Compare May 12, 2023 03:33
@Rory-Z Rory-Z force-pushed the style/change-falgset branch from ab82d00 to 595fe94 Compare May 16, 2023 09:21
@Rory-Z Rory-Z requested a review from logo306142054 May 16, 2023 09:21
and refactor utils.extendEnvs utils.extendArgs utils.extendPorts

Signed-off-by: Rory Z <rory-z@outlook.com>
@Rory-Z Rory-Z force-pushed the style/change-falgset branch from 595fe94 to aef87ff Compare May 17, 2023 07:26
@Rory-Z Rory-Z merged commit 1a22c55 into hstreamdb:main May 18, 2023
@Rory-Z Rory-Z deleted the style/change-falgset branch May 18, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants