Paramaterized paths#405
Merged
Merged
Conversation
just send an announcement to yourself.
to change the urls of the admin page, the my account page and of invites. Seems to work, but need to check all the code over and test.
various subpath combos seem to work, and trailing slashes from them are trimmed (including for the empty admin path "/", which is now "" by default).
tailwind command taking part-bundle and turning it into v3bundle didn't
do anything when no changes occurred, so v3bundle kept on being left
untouched, and therefore with an old timestamp. part-bundle and
v3bundle are both deleted before CSS is built, so the tailwind
command always generates a new file.
popstate messages from the browser don't have an event.state, and i don't even know what the overridePopState stuff is trying to do. If event.state is null, try window.location.hash, or the last part of the URL path.
just mentioned that you should check the URL before refreshing if you changed host/port/subfolder/etc.
use a container to kinda fix the max-width. Tried this on admin but it messed too much up to bother (the accounts table specifically doesn't like it).
✅ Deploy Preview for jfa-go canceled.
|
Owner
Author
|
Merging so I can get some proper feedback. I've done a reasonable amount of testing this time at least. |
Owner
Author
|
Fixes #385 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifiable admin, my account and invite page paths. Advanced setting; set in Settings > URL Paths.
Only the pages themselves are affected, API routes remain as-is, EXCEPT:
app.Telegram/DiscordVerifiedInvite,app.DiscordServerInvite,app.MatrixCheckPINandapp.MatrixSendPIN. These are all subpaths of the invite form, and need the invite in the path so will remain as subpaths (maybe revisit this in future?). I have added notes about these paths to the API docs.Page subpaths are in the
PAGESglobal struct in Go, andwindow.pagesin typescript.Other bits:
gcHTMLis nowapp.gcHTML, takesPageparameter and templates in usual stuff itself (PAGES, cssVersion/Class, email/tg/dc/mxEnabled, etc.). Language strings still aren't, as the way it's done for each page can differ.windowin each page's template. The usual ones are now done in header.html (confirmed to not cause issues on dumb pages like crash.html).