Skip to content

Cursor pointer UX consistency#194

Merged
hrfee merged 2 commits into
hrfee:mainfrom
KeyboardDabbler:main
Jan 30, 2022
Merged

Cursor pointer UX consistency#194
hrfee merged 2 commits into
hrfee:mainfrom
KeyboardDabbler:main

Conversation

@KeyboardDabbler

@KeyboardDabbler KeyboardDabbler commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Personal preference but I have noticed some selectable elements currently are set to cursor: default. I have changed the following to cursor: pointer.

  • checkbox's on the accounts and settings page
  • edit email button on accounts page
  • invite page, captcha refresh button
  • modal close

@netlify

netlify Bot commented Jan 29, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for jfa-go canceled.

🔨 Explore the source changes: bfcad6c

🔍 Inspect the deploy log: https://app.netlify.com/sites/jfa-go/deploys/61f5382e3902d7000854fc95

@JamsRepos

Copy link
Copy Markdown

I'm no maintainer but because Tailwind is now included by default, we should aim to move everything over to using Tailwind classes. You can do this by adding the class cursor-pointer or for the sake of the before before:cursor-pointer. Better to move away from excess CSS declarations. I'd like to eventually get the whole entire thing over also but due to the JS and other components looking for class names instead of ID's it's a little more tiresome.

@KeyboardDabbler

Copy link
Copy Markdown
Contributor Author

I have just came back to jfa-go after a year, I didn't realize there is currently a CSS refactor currently ongoing.
I fully agree with you're comments and will look to update using tailwind instead.

@hrfee hrfee merged commit a003921 into hrfee:main Jan 30, 2022
@hrfee

hrfee commented Jan 30, 2022

Copy link
Copy Markdown
Owner

Thanks for this, Tailwind would definitely be better but since it doesn't affect the actual experience i'll merge so it's included in 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants