Skip to content

Further Mobile Optimisations#191

Merged
hrfee merged 7 commits into
hrfee:mainfrom
JamsRepos:main
Jan 30, 2022
Merged

Further Mobile Optimisations#191
hrfee merged 7 commits into
hrfee:mainfrom
JamsRepos:main

Conversation

@JamsRepos

Copy link
Copy Markdown

This PR includes more mobile optimisations primarily for the modals on mobile as they squish too much, also a little converting to more Tailwind less style-sheets.

@netlify

netlify Bot commented Jan 28, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for jfa-go canceled.

🔨 Explore the source changes: ecbff16

🔍 Inspect the deploy log: https://app.netlify.com/sites/jfa-go/deploys/61f6bc197d0e6c0007fea44a

@JamsRepos

Copy link
Copy Markdown
Author

@hrfee not sure what this compile error is related to as I'm on my phone, care to take a look? Works fine on a local instance.

@hrfee

hrfee commented Jan 30, 2022

Copy link
Copy Markdown
Owner

Accidentally just pushed to your fork lmao, but the jfa-go.com build was already broken. Compilation worked fine, and my commit should get rid of the errors.

@hrfee

hrfee commented Jan 30, 2022

Copy link
Copy Markdown
Owner

This looks great, also makes me realize i need to test on my phone more often 😂. One thing i did notice is that there's no longer a modal opening animation. I wasn't a big fan of the old one anyway but do you think a quick fade-in like there is for closing would look alright?

@JamsRepos

Copy link
Copy Markdown
Author

I've never noticed one, where was it supposed to be? One can be added with the transition class and a duration-500 or something, I'm not on my PC at the minute to test.

now a simple fade-in/fade-out, which is part of tailwind.config.js
rather than modal.css.
@hrfee hrfee merged commit e814af1 into hrfee:main Jan 30, 2022
@hrfee

hrfee commented Jan 30, 2022

Copy link
Copy Markdown
Owner

I've added a simple fade-in and fade-out which uses animate-fade-in and animate-fade-out classes. Everything else looks good so i'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants