replaced single-shot HTTP requests with retry logic#42
Merged
hrbrmstr merged 2 commits intohrbrmstr:masterfrom May 6, 2020
jameslamb:retry-logic
Merged
replaced single-shot HTTP requests with retry logic#42hrbrmstr merged 2 commits intohrbrmstr:masterfrom jameslamb:retry-logic
hrbrmstr merged 2 commits intohrbrmstr:masterfrom
jameslamb:retry-logic
Conversation
Owner
|
This is brilliant! #ty!!! Can you also update |
Contributor
Author
|
@hrbrmstr sure, I'll do that right now! I'll take a look at the other issues too, maybe there are other things I can help with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this project!
In this PR, I'd like to propose swapping out calls to
httr::POST(),httr::HEAD()etc. withhttr::RETRY(). This will make the package more resilient to transient problems like brief network outages or periods where Drill is briefly unavailable. In my experience, using retry logic almost always improves the user experience with HTTP clients.I'm working on chircollab/chircollab20#1 as part of Chicago R Collab, an R 'unconference' in Chicago.