Skip to content

Simplify non-Windows build tag#162

Closed
mohammed90 wants to merge 1 commit intohpcloud:masterfrom
mohammed90:patch-1
Closed

Simplify non-Windows build tag#162
mohammed90 wants to merge 1 commit intohpcloud:masterfrom
mohammed90:patch-1

Conversation

@mohammed90
Copy link
Copy Markdown

Fixes #161

@mohammed90
Copy link
Copy Markdown
Author

The failure is because travis-ci build uses Go 1.8 max, and there's dependency on the package math/bits which is introduced in Go 1.9. The build with Go tip on Travis passes.

@mholt
Copy link
Copy Markdown

mholt commented Nov 15, 2019

Oo, yes please. Would love to see this merged.

@nxadm
Copy link
Copy Markdown

nxadm commented Nov 19, 2019

FWIW I added your changes to my fork of tail where I try to keep up with usefull PRs for the dormant upstream project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't compile for Dragonfly or Illumos

3 participants