-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Describe the bug
In a preview apps deploy context, if the preview app has already been deployed once, and we retrigger a deployment (repository_dispatch) without any code changes, the workflow completes successfully, but ArgoCD does not trigger a sync event to finalize the deployment. This leads to deployments appearing as stuck or incomplete in ArgoCD, even though operations from the workflow appear successful.
Egde cases that have this issue:
- I want to redeploy without code change for demonstration purpose
- I want to redeploy without code change because someting has changed in the ArgoCD config itself (but not)
- I want to redeploy without code change because I dont rembember that I had already deployed or I wan tto be sure that I deployt the last version.
To Reproduce
Steps to reproduce the behavior:
- Deploy a preview app using the workflow.
- Ensure successful deployment and ArgoCD sync.
- Without making any code changes, retrigger the deployment workflow for the same preview app.
- Observe that ArgoCD does NOT trigger a sync event for the Application manifest.
Example of failing deployment: cigales-cloud/landing-page#222
Expected behavior
Retriggering a preview app deployment, even with no code changes, should cause ArgoCD to trigger a sync event and finalize deployment, ensuring the application state in ArgoCD matches the intended state.
Additional context
- Optimized deployment workflows should ensure proper finalization/sync in ArgoCD on every deployment trigger, even if there is no code change. A possible workaround is to force an update or sync in ArgoCD as part of the workflow.
- Refer to the ArgoCD App Of Apps pattern documentation for best practices.
- Workflow file: .github/workflows/deploy-argocd-app-of-apps.yml