Skip to content

fix: Argocd does not sync on redeploy of already deployed preview apps without code change #227

@neilime

Description

@neilime

Describe the bug
In a preview apps deploy context, if the preview app has already been deployed once, and we retrigger a deployment (repository_dispatch) without any code changes, the workflow completes successfully, but ArgoCD does not trigger a sync event to finalize the deployment. This leads to deployments appearing as stuck or incomplete in ArgoCD, even though operations from the workflow appear successful.

Egde cases that have this issue:

  • I want to redeploy without code change for demonstration purpose
  • I want to redeploy without code change because someting has changed in the ArgoCD config itself (but not)
  • I want to redeploy without code change because I dont rembember that I had already deployed or I wan tto be sure that I deployt the last version.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy a preview app using the workflow.
  2. Ensure successful deployment and ArgoCD sync.
  3. Without making any code changes, retrigger the deployment workflow for the same preview app.
  4. Observe that ArgoCD does NOT trigger a sync event for the Application manifest.

Example of failing deployment: cigales-cloud/landing-page#222

Expected behavior
Retriggering a preview app deployment, even with no code changes, should cause ArgoCD to trigger a sync event and finalize deployment, ensuring the application state in ArgoCD matches the intended state.

Additional context

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions