Merged
Conversation
houseroad
reviewed
Mar 28, 2019
foxi/onnxifi.h
Outdated
| * If it is a quantized tensor, the value should be set to 1. | ||
| * By default it should be set to 0. | ||
| */ | ||
| unsigned char is_quantized; |
Owner
There was a problem hiding this comment.
we already use int32_t anyway, why hesitate using uint8_t?
Collaborator
Author
There was a problem hiding this comment.
Then let me try uint8_t? didnt see the difference...
Owner
There was a problem hiding this comment.
it's weird to use char to store the number, which means you need explict conversion. So if it's possible, that's use uint8 instead
Collaborator
Author
There was a problem hiding this comment.
ok, let me change it.
Collaborator
|
How to sync it back? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rt, add foxi quantization.
pls sync this to fbcode asap, thanks.