Perform same-page visit proposals without recreating the current destination#292
Merged
Perform same-page visit proposals without recreating the current destination#292
Conversation
…isting fragment with a new one for a visit
* main: Bump minSdkVersion to 26 in the docs Bump minSdkVersion to 26 Upgrade to SDK 34 and bump dependencies to latest versions
…hout any flickering. Use Turbo.navigator.location to determine the current location, so it works immediately cold boots and Turbo visits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when Turbo submits a form and redirects back to the same page, the current destination fragment is recreated. This displays a visual flash and doesn't work well with the upcoming Turbo 8 morphing feature.
To fix this, visit proposals for the same page are no longer proposed to the app. Instead, an immediate Turbo visit is started in the WebView so Turbo can seamlessly handle the visit and provide a better visual update with morphing.