Scope willRender to PageRenderer only#741
Open
seanpdoyle wants to merge 1 commit intohotwired:mainfrom
Open
Conversation
978ccd8 to
279a9ca
Compare
279a9ca to
82982b8
Compare
2aaba5c to
e23abe0
Compare
e23abe0 to
f5cc8fc
Compare
f5cc8fc to
af0c77c
Compare
e4824da to
12b91f5
Compare
The `willRender` property introduced to the generic `Renderer<E, S>` only applies to the `PageRenderer` specialized sub-class. This commit removes it from the root class and declares a `PageRenderer.constructor()` method to accept and assign it.
12b91f5 to
a34961e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
willRenderproperty introduced to the genericRenderer<E, S>only applies to thePageRendererspecialized sub-class. This commit removes it from the root class and declares aPageRenderer.constructor()method to accept and assign it.