Encode Visit Action into Turbo-Action: header#694
Open
seanpdoyle wants to merge 1 commit intohotwired:mainfrom
Open
Encode Visit Action into Turbo-Action: header#694seanpdoyle wants to merge 1 commit intohotwired:mainfrom
Turbo-Action: header#694seanpdoyle wants to merge 1 commit intohotwired:mainfrom
Conversation
marcoroth
approved these changes
Sep 13, 2022
18eeb72 to
836a00a
Compare
836a00a to
c0819b1
Compare
c0819b1 to
1206710
Compare
f9ae4d2 to
41d489f
Compare
5fa4991 to
b2e2b09
Compare
b2e2b09 to
99814da
Compare
99814da to
969e56a
Compare
969e56a to
4ef183a
Compare
4ef183a to
9c804ca
Compare
9c804ca to
9b287c7
Compare
9b287c7 to
8e724d3
Compare
When initiating a `Visit` from an `<a data-turbo-action="...">` element, encode the Action value into the request's `Turbo-Action:` header. Similarly, when submitting a `<form data-turbo-action="...">`, encode the value into the header. If a `<turbo-frame>` is navigated with an Action, encode the action along with the `Turbo-Frame:` header.
8e724d3 to
cf337b9
Compare
|
This is exactly what I was trying to achieve here hotwired/turbo-rails#594. I was barking to the wrong tree 😅.
On this last point is where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initiating a
Visitfrom an<a data-turbo-action="...">element,encode the Action value into the request's
Turbo-Action:header.Similarly, when submitting a
<form data-turbo-action="...">, encodethe value into the header.
If a
<turbo-frame>is navigated with an Action, encode the actionalong with the
Turbo-Frame:header.