Dispatch turbo:fetch-request-error during Visits#685
Merged
dhh merged 1 commit intohotwired:mainfrom Sep 14, 2022
Merged
Conversation
This was referenced Aug 16, 2022
cb34bf6 to
731eb91
Compare
283bc3b to
8c85542
Compare
Follow-up to hotwired#640 Related to hotwired/turbo-site#110 When a `Visit` results in a `fetch` error (like when the browser is offline), dispatch a `turbo:fetch-request-error` event in the same style as `<turbo-frame>`- and `<form>`-initiated `fetch` errors. For the sake of consistency, also make the `TurboFetchRequestErrorEvent` cancelable. Along with the implementation change, this commit also adds test coverage to ensure that the `Event.target` is correct for `<turbo-frame>` and `<form>` error events.
8c85542 to
e3be82f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #640
Related to hotwired/turbo-site#110
When a
Visitresults in afetcherror (like when the browser isoffline), dispatch a
turbo:fetch-request-errorevent in the same styleas
<turbo-frame>- and<form>-initiatedfetcherrors.For the sake of consistency, also make the
TurboFetchRequestErrorEventcancelable.
Along with the implementation change, this commit also adds test
coverage to ensure that the
Event.targetis correct for<turbo-frame>and<form>error events.