data-turbo-stream links should not set aria-busy#681
Merged
dhh merged 1 commit intohotwired:mainfrom Aug 16, 2022
kevinmcconnell:data-turbo-stream-no-busy-state
Merged
data-turbo-stream links should not set aria-busy#681dhh merged 1 commit intohotwired:mainfrom kevinmcconnell:data-turbo-stream-no-busy-state
data-turbo-stream links should not set aria-busy#681dhh merged 1 commit intohotwired:mainfrom
kevinmcconnell:data-turbo-stream-no-busy-state
Conversation
Normally when following a link Turbo sets `[aria-busy="true"]` on the document element. When the visit is complete, that attribute is removed. However, when using `[data-turbo-stream]` to request a stream response to a link, there is no visit to complete. That presented as a bug where `aria-busy` was set at the start of the operation, but never cleared. To solve this, we avoid setting the `aria-busy` attribute for links that have a `data-turbo-stream` attribute.
seanpdoyle
approved these changes
Aug 12, 2022
This was referenced Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally when following a link Turbo sets
[aria-busy="true"]on thedocument element. When the visit is complete, that attribute is removed.
However, when using
[data-turbo-stream]to request a stream responseto a link, there is no visit to complete. That presented as a bug where
aria-busywas set at the start of the operation, but never cleared.To solve this, we avoid setting the
aria-busyattribute for links thathave a
data-turbo-streamattribute.