Prevent form links from submitting multiple requests#645
Merged
dhh merged 1 commit intohotwired:mainfrom Jul 28, 2022
Merged
Conversation
8b6e2b8 to
b1be7e9
Compare
The `LinkInterceptor` class contains some Frame-specific checks that were at the root of `<a data-turbo-method="...">` element clicks submitting multiple HTTP requests. To resolve the underlying issue, this commit changes the `FormLinkInterceptor` class to rely on an instance of `LinkClickObserver` instead of `LinkInterceptor`. In order to make that possible, this commit also extends the `LinkClickObserver` to accept a second argument to server as the [EventTarget][] for the `click` event listeners. As a consumer, the `FormLinkInterceptor` instances attached to `<turbo-frame>` element scope their listeners to the element, while the `Session`'s `FormLinkInterceptor` instance attaches a catch-all listener to the `window`. Since this commit changes the underlying event listening mechanism, it also renames the `FormLinkInterceptor` and delegate to `FormLinkClickObserver` to match the `LinkClickObserver` naming patterns. [EventTarget]: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget
b1be7e9 to
afeb52d
Compare
This was referenced Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LinkInterceptorclass contains some Frame-specific checks thatwere at the root of
<a data-turbo-method="...">element clickssubmitting multiple HTTP requests.
To resolve the underlying issue, this commit changes the
FormLinkInterceptorclass to rely on an instance ofLinkClickObserverinstead ofLinkInterceptor.In order to make that possible, this commit also extends the
LinkClickObserverto accept a second argument to server as theEventTarget for the
clickevent listeners. As a consumer, theFormLinkInterceptorinstances attached to<turbo-frame>elementscope their listeners to the element, while the
Session'sFormLinkInterceptorinstance attaches a catch-all listener to thewindow.Since this commit changes the underlying event listening mechanism, it
also renames the
FormLinkInterceptorand delegate toFormLinkClickObserverto match theLinkClickObservernamingpatterns.