Modify SubmitEvent polyfill to read type property#49
Merged
Conversation
Follow-up to #1 (comment) Replaces the `SubmitEvent` polyfill's `type` attribute access with [`type property access][]. [type]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLButtonElement#Properties
Contributor
Author
|
The original code for the polyfill was written before we had a functional test suite covering Form Submissions. Now that we have a suite to cover this behavior, would it be possible to run it in CI against multiple browsers via a tool like Browser Stack? That way, we can have some confidence in the behavior applying correctly in polyfilled browser environments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1 (comment)
Replaces the
SubmitEventpolyfill'stypeattribute access with`type property access.