Closed
Conversation
nbgoodall
reviewed
Dec 23, 2020
ca05eec to
9bbcd4c
Compare
|
This is the only thing stopping me from using |
|
Apologies for the additional bump, but this has been in waiting since January and would be an amazing addition. |
|
@domchristie i don’t know the status of who would merge things at the moment, but, to help, perhaps you could resolve the conflicts? And, while we’re waiting, is there any decent workaround? Thanks! |
|
Seems like this is orphaned after the recent changes at basecamp. Pinging @dhh ! |
Member
|
Happy to see this carried forward, if someone else wants to pickup the PR. |
Merged
Contributor
|
@dhh The feature looks great. I will prepare an updated PR for it. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like
turbo:before-visit, this pull request makes theturbo:before-renderevent cancellable withpreventDefault. Additionally it adds arendermethod to the event to let the render process resolve (using Promises). This effectively makes rendering pausable; useful for waiting for exit animations, and could open the door to custom renderers e.g. DOM diffing. A basic example might look like:Here's a demo of some basic animation possibilities: https://laser-crawling-chanter.glitch.me/ (View source)
This pull request also adds the Visit's
actionto the event detail, making it possible to change the behaviour depending on whether it's anadvanceorrestore.If there's interest, I could do similar features for streams/frames + add documentation.
There are a few old Turbolinks issues that make reference to something like this: