Skip to content

Disable CR implicit init#9

Merged
hopsoft merged 1 commit intomainfrom
hopsoft/disable-cr
Sep 6, 2023
Merged

Disable CR implicit init#9
hopsoft merged 1 commit intomainfrom
hopsoft/disable-cr

Conversation

@hopsoft
Copy link
Owner

@hopsoft hopsoft commented Sep 6, 2023

No description provided.

@hopsoft hopsoft merged commit ef23519 into main Sep 6, 2023
@hopsoft hopsoft deleted the hopsoft/disable-cr branch September 6, 2023 19:44
@hopsoft
Copy link
Owner Author

hopsoft commented Sep 6, 2023

@julianrubisch I ended up needing to cut this release as a hotfix without the implicit CableReady initialization. The problem was twofold.

  1. The Elements lib had a bug that was double registering Command event delegates, but I identified and fixed this bug after the devtools was extracted into it's own lib.
  2. The Devtools lib had a bug that implicitly initialized the CR devtools regardless of environment. I needed to disable that so I could ship the other fix.

I have some ideas on how to refactor for explicit initialization for CableReady devtools, but didn't have time to implement over the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant