Made the token list a table#1
Merged
hoonweiting merged 1 commit intohoonweiting:2849-token-type-docsfrom Oct 5, 2021
Merged
Conversation
Owner
|
Oh man thank you so much for doing this! I'll take a look at it tomorrow :) |
hoonweiting
approved these changes
Oct 5, 2021
Owner
hoonweiting
left a comment
There was a problem hiding this comment.
I really, really like this! It is so much neater than the vanilla definition list, and the sorting of tokens into groups helps a ton too.
But I also want to use semantically-correct HTML tags as far as possible, so I'll see what I can do with CSS. I don't have very high hopes for it, so that might not come to fruition at all :P
Owner
|
Clearly I am not familiar enough with merging PRs :") @ silly extra merge commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the PR I promised here.
I converted the definition list into a table. The design and structure are heavily influenced by HighlightJS' scope reference. I also shortened many examples.