Skip to content

fix(session): Use env adapter to access AUTH_SECRET#1929

Merged
yusukebe merged 3 commits into
honojs:mainfrom
orpheus6678:patch-1
Jun 5, 2026
Merged

fix(session): Use env adapter to access AUTH_SECRET#1929
yusukebe merged 3 commits into
honojs:mainfrom
orpheus6678:patch-1

Conversation

@orpheus6678

Copy link
Copy Markdown
Contributor

This facilities the retrieval of AUTH_SECRET across different runtimes as opposed to just cloudflare workers.

This facilities the retrieval of AUTH_SECRET across different runtimes as opposed to just cloudflare workers.
@changeset-bot

changeset-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 50266af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/session Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BarryThePenguin BarryThePenguin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! Can you add a changeset too?

@yusukebe yusukebe changed the title Use env adapter to access AUTH_SECRET fix(session): Use env adapter to access AUTH_SECRET Jun 4, 2026
@orpheus6678

Copy link
Copy Markdown
Contributor Author

my bad for not adding the changeset before, i was being lazy :) i hope i did it right? first time using em

@BarryThePenguin

Copy link
Copy Markdown
Contributor

Looks good 👍🏻

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (c70fca6) to head (50266af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1929   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files         115      115           
  Lines        3991     3991           
  Branches     1031     1031           
=======================================
  Hits         3668     3668           
  Misses        287      287           
  Partials       36       36           
Flag Coverage Δ
session 98.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe

yusukebe commented Jun 5, 2026

Copy link
Copy Markdown
Member

@orpheus6678 @BarryThePenguin Thank you!

@yusukebe yusukebe merged commit 5c31f32 into honojs:main Jun 5, 2026
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants