Skip to content

chore(oidc-auth): bump oauth4webapi from 2.6.0 to 3.8.6#1916

Merged
yusukebe merged 1 commit into
honojs:mainfrom
thegu5:bump-oidc-dep
Jun 1, 2026
Merged

chore(oidc-auth): bump oauth4webapi from 2.6.0 to 3.8.6#1916
yusukebe merged 1 commit into
honojs:mainfrom
thegu5:bump-oidc-dep

Conversation

@thegu5

@thegu5 thegu5 commented May 31, 2026

Copy link
Copy Markdown
Contributor

The breaking changes are in v3.0.0. Error handling needed to be changed to try/catch, some of its methods were renamed, and some of its methods now require explicit ClientAuth information.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

@changeset-bot

changeset-bot Bot commented May 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0c6a594

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/oidc-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Assisted-by: github-copilot-cli:gpt-5.2-codex
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.86%. Comparing base (1e8892a) to head (0c6a594).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/oidc-auth/src/index.ts 50.00% 10 Missing and 4 partials ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1916      +/-   ##
==========================================
- Coverage   92.08%   91.86%   -0.22%     
==========================================
  Files         115      115              
  Lines        3965     3972       +7     
  Branches     1023     1025       +2     
==========================================
- Hits         3651     3649       -2     
- Misses        282      287       +5     
- Partials       32       36       +4     
Flag Coverage Δ
oidc-auth 93.15% <50.00%> (-3.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe

yusukebe commented Jun 1, 2026

Copy link
Copy Markdown
Member

@thegu5 Thanks!

@yusukebe yusukebe merged commit d939c2d into honojs:main Jun 1, 2026
95 of 98 checks passed
@github-actions github-actions Bot mentioned this pull request Jun 1, 2026
@thegu5 thegu5 deleted the bump-oidc-dep branch June 1, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants