Skip to content

Treat compressed lambda-edge responses as binary#4874

Closed
ShipItAndPray wants to merge 2 commits into
honojs:mainfrom
ShipItAndPray:fix/lambda-edge-compressed-body-base64
Closed

Treat compressed lambda-edge responses as binary#4874
ShipItAndPray wants to merge 2 commits into
honojs:mainfrom
ShipItAndPray:fix/lambda-edge-compressed-body-base64

Conversation

@ShipItAndPray

Copy link
Copy Markdown

Summary

  • treat non-identity Content-Encoding values as binary in the lambda-edge adapter
  • base64-encode compressed responses so CloudFront receives valid payloads
  • add a regression test that exercises the compress middleware through the adapter

Fixes #4254

Validation

  • bunx vitest run src/adapter/lambda-edge/handler.test.ts
  • bunx eslint src/adapter/lambda-edge/handler.ts src/adapter/lambda-edge/handler.test.ts
  • git diff --check

@yusukebe

Copy link
Copy Markdown
Member

This PR includes not related changes. Slop PR. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hono/lambda-edge adapter should treat compressed response body as binary

3 participants