fix(lambda-edge): avoid callback handler deprecation on NODEJS_24_X#4782
Merged
yusukebe merged 2 commits intohonojs:mainfrom Mar 10, 2026
Merged
fix(lambda-edge): avoid callback handler deprecation on NODEJS_24_X#4782yusukebe merged 2 commits intohonojs:mainfrom
yusukebe merged 2 commits intohonojs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4782 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 177 177
Lines 11578 11579 +1
Branches 3368 3368
=======================================
+ Hits 10591 10592 +1
Misses 986 986
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@t0waxx Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4772
Problem
handle()fromhono/lambda-edgereturns an async handler withFunction.length === 3becausecallbackis a formal parameter. AWS Lambda NODEJS_24_X determines handler type byFunction.length— when it's>= 3, the runtime treats it as a callback-style handler and throwsRuntime.CallbackHandlerDeprecated.Solution
Replace the three formal parameters
(event, context, callback)with(event, ...args)and destructurecontextandcallbackinternally. This reducesFunction.lengthto1while preserving positional callback compatibility for older runtimes.Before
After
Tests Added
handler.length <= 2(regression test for the root cause)handler(event, undefined, callback)Testing Note
handler.lengthissue, which is the documented cause of theRuntime.CallbackHandlerDeprecatederror in the NODEJS_24_X runtime.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code