docs(bun/websocket): Fixed a typo in hono/bun deprecation message and updated test.#4618
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4618 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 173 173
Lines 11256 11256
Branches 3265 3266 +1
=======================================
Hits 10307 10307
Misses 948 948
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hey @Itsnotaka Thanks. Nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo in createBunWebSocket deprecation message
The deprecation notice incorrectly referenced createWebSocket which doesn't exist. Changed to upgradeWebSocket which is the actual export users should migrate to.
Also fixed the test assertion which was comparing variables to themselves instead of verifying the factory returns the correct exports.
Tests pass:
bun run vitest run src/adapter/bun/websocket.test.ts