fix(types): cannot .use non-return mw from createMiddleware#4465
Merged
yusukebe merged 2 commits intohonojs:mainfrom Oct 17, 2025
Merged
fix(types): cannot .use non-return mw from createMiddleware#4465yusukebe merged 2 commits intohonojs:mainfrom
.use non-return mw from createMiddleware#4465yusukebe merged 2 commits intohonojs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4465 +/- ##
=======================================
Coverage 91.36% 91.36%
=======================================
Files 173 173
Lines 11146 11146
Branches 3214 3214
=======================================
Hits 10183 10183
Misses 962 962
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e33ebba to
4e679b5
Compare
Member
|
@NamesMT Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4462
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the codeAdditional context
TS seems to does not raise an error when
Rdoesn't actuallyextends HandlerResponse<any>, and implicitly typeRasHandlerResponse<any>directly for cases whereRis non-extending.This PR checks for a case where
Rmight bevoid, and assign it as non-typedResponse, i.e.: the default value, so it prevents the created middleware beingHandlerResponse<any>and broke some types chain like direct.use.