fix(types): missing response type on OnHandlerInterface#3852
Merged
yusukebe merged 1 commit intohonojs:mainfrom Jan 25, 2025
Merged
fix(types): missing response type on OnHandlerInterface#3852yusukebe merged 1 commit intohonojs:mainfrom
OnHandlerInterface#3852yusukebe merged 1 commit intohonojs:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3852 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 161 161
Lines 10242 10242
Branches 2891 2863 -28
=======================================
Hits 9353 9353
Misses 888 888
Partials 1 1 ☔ View full report in Codecov by Sentry. |
OnHandlerInterfaceOnHandlerInterface
Member
|
Thanks! This should be fixed. I'll merge this. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code