Skip to content

chore(deps): replace chalk with picocolors#95

Merged
yusukebe merged 1 commit intohonojs:mainfrom
ryoppippi:feat/chalk
Apr 21, 2025
Merged

chore(deps): replace chalk with picocolors#95
yusukebe merged 1 commit intohonojs:mainfrom
ryoppippi:feat/chalk

Conversation

@ryoppippi
Copy link
Copy Markdown
Contributor

Hi @yusukebe !
This pr replace chalk with picocolors.
It slightly reduces bundle size (5kb or so)

@ryuapp
Copy link
Copy Markdown
Contributor

ryuapp commented Apr 17, 2025

[quick reply] Using picocolors increases bundle size because other libraries depend on chalk.

@ryoppippi
Copy link
Copy Markdown
Contributor Author

Oh really! Which one?

@ryoppippi
Copy link
Copy Markdown
Contributor Author

ryoppippi commented Apr 17, 2025

I built it in my local and I found that it is smaller

@ryuapp
Copy link
Copy Markdown
Contributor

ryuapp commented Apr 17, 2025

I built it in my local and I found that it is smaller

Oops, sry you are right.
The current codebase does not use any functions that use chalk, so your optimization is right.

// bin size
main
552000 Byte
This PR
536892 Byte

@ryoppippi ryoppippi marked this pull request as ready for review April 18, 2025 19:00
@ryoppippi
Copy link
Copy Markdown
Contributor Author

Thank you ! Need to review it!

@yusukebe yusukebe changed the title feat: replace chalk with picocolors chore(deps): replace chalk with picocolors Apr 21, 2025
Copy link
Copy Markdown
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Copy Markdown
Member

@ryoppippi

Thanks! I'll merge it and release a new version.

@yusukebe yusukebe merged commit f7cdbd5 into honojs:main Apr 21, 2025
3 checks passed
@ryoppippi
Copy link
Copy Markdown
Contributor Author

Thank you!

@ryoppippi ryoppippi deleted the feat/chalk branch April 21, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants