Skip to content

fix: does not work install option#88

Merged
yusukebe merged 1 commit intohonojs:mainfrom
chimame:fix-does-not-work-install-option
Mar 19, 2025
Merged

fix: does not work install option#88
yusukebe merged 1 commit intohonojs:mainfrom
chimame:fix-does-not-work-install-option

Conversation

@chimame
Copy link
Copy Markdown
Contributor

@chimame chimame commented Mar 19, 2025

Overview

I tried using the install option, but npm install and other options did not work automatically. So I fixed it so that the install option works.

image

Chnages

  • Fixed so that the value of --install on the command line can be obtained correctly.

Other Changes

  • I tried running bun install in the project setup, but a difference was found in the lock file, so I committed it.
  • I also fixed the --offline on the command line, as it seemed to be a problem with the --install option.

Copy link
Copy Markdown
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Copy Markdown
Member

@chimame

I've confirmed it works well on my machine. Looks good. Thank you!

@yusukebe yusukebe merged commit 0eeca47 into honojs:main Mar 19, 2025
3 checks passed
@chimame chimame deleted the fix-does-not-work-install-option branch March 19, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants