Skip to content

refactor: removed unused package and minor type corrections#86

Merged
yusukebe merged 2 commits intohonojs:mainfrom
MathurAditya724:main
Mar 11, 2025
Merged

refactor: removed unused package and minor type corrections#86
yusukebe merged 2 commits intohonojs:mainfrom
MathurAditya724:main

Conversation

@MathurAditya724
Copy link
Copy Markdown
Contributor

Came across these minor changes

  • Type corrections
  • Removed unused package @types/yargs-parser

@yusukebe
Copy link
Copy Markdown
Member

Hi @MathurAditya724

Thank you for the PR. Is this really a "fix"? I think this change will not resolve the bug or problem for the user side. So we call it a "refactor" and don't have to release a new version, right?

@MathurAditya724 MathurAditya724 changed the title fix: removed unused package and minor type corrections refactor: removed unused package and minor type corrections Mar 11, 2025
@MathurAditya724
Copy link
Copy Markdown
Contributor Author

I have changed the title and yes, we don't need to create a new release for this.

@yusukebe
Copy link
Copy Markdown
Member

@MathurAditya724 Thank!! Merging.

@yusukebe yusukebe merged commit fa3fefc into honojs:main Mar 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants