Skip to content

fix: Do not show the info log of cd .#102

Merged
yusukebe merged 4 commits intohonojs:mainfrom
max-programming:patch-1
May 18, 2025
Merged

fix: Do not show the info log of cd .#102
yusukebe merged 4 commits intohonojs:mainfrom
max-programming:patch-1

Conversation

@max-programming
Copy link
Copy Markdown
Contributor

I stumbled across this when choosing the target directory as . (current dir) when creating a new project
image
This PR does not show this console log when the target directory is current

@yusukebe yusukebe changed the title Do not show the info log of cd . fix: Do not show the info log of cd . May 18, 2025
Copy link
Copy Markdown
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

const resolvedTarget = path.resolve(target)
const currentDir = process.cwd()

if (resolvedTarget !== currentDir) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea.

@yusukebe
Copy link
Copy Markdown
Member

@max-programming Thanks! I'll merge it and release a new version.

@yusukebe yusukebe merged commit e811937 into honojs:main May 18, 2025
3 checks passed
@max-programming max-programming deleted the patch-1 branch June 2, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants