Detect host support for CPU realtime + add an option for enable it#2602
Merged
Detect host support for CPU realtime + add an option for enable it#2602
Conversation
ludeeus
approved these changes
Feb 22, 2021
frenck
reviewed
Feb 22, 2021
| @property | ||
| def cpu_rt_runtime(self) -> Optional[int]: | ||
| """Limit CPU real-time runtime in microseconds.""" | ||
| if not self.sys_docker.info.support_cpu_realtime: |
Member
There was a problem hiding this comment.
Should we log this happens? As in, the creator expected this to work maybe?
Member
Author
There was a problem hiding this comment.
It would work because it's disabled. Only HAOS have the current problem with the wrong implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Since docker don't handle that for us, we check if the kernel module is loaded. But as we not know if the local docker is setup correctly, we add also an option
SUPERVISOR_CPU_RT=1to enable this feature.Type of change
Additional information
Checklist
black --fast supervisor tests)If API endpoints of add-on configuration are added/changed: