Disable overlayfs features not used by Docker#2773
Merged
agners merged 1 commit intohome-assistant:devfrom Sep 26, 2023
Merged
Conversation
Currently `CONFIG_OVERLAY_FS_METACOPY` and `CONFIG_OVERLAY_FS_REDIRECT_DIR` kernel options are enabled but not preferred by Docker. The metadata copy feature is disabled by default, and also not actively used by the overlayfs2 driver (see moby/moby@2c3d1f7). So the metadata copy config is not really problematic per se. However, it enables the redirect_dir feature. And a kernel which has the redirect_dir feature compiled in also enables it by default. This actually makes the overlayfs2 driver to fallback to naive diff, which is, from what I understand, slower than the overlayfs native diff (see also moby/moby@49c3a7c). The Docker daemon is also reporting this on startup: Not using native diff for overlay2, this may cause degraded performance for building images: kernel has CONFIG_OVERLAY_FS_REDIRECT_DIR enabled Currently `CONFIG_OVERLAY_FS_METACOPY` is enabled, and it also enables `CONFIG_OVERLAY_FS_REDIRECT_DIR`. There was already a previous attempt to disable the latter (see home-assistant#2067). Disable both configs explicitly until Docker is able to use them.
9592a26 to
323c1a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
CONFIG_OVERLAY_FS_METACOPYandCONFIG_OVERLAY_FS_REDIRECT_DIRkernel options are enabled but not preferred by Docker. The metadata copy feature is disabled by default, and also not actively used by the overlayfs2 driver (see moby/moby@2c3d1f7). So the metadata copy config is not really problematic per se. However, it enables the redirect_dir feature. And a kernel which has the redirect_dir feature compiled in also enables it by default. This actually makes the overlayfs2 driver to fallback to naive diff, which is, from what I understand, slower than the overlayfs native diff (see also moby/moby@49c3a7c). The Docker daemon is also reporting this on startup:Currently
CONFIG_OVERLAY_FS_METACOPYis enabled, and it also enablesCONFIG_OVERLAY_FS_REDIRECT_DIR. There was already a previous attempt to disable the latter (see #2067).Disable both configs explicitly until Docker is able to use them.