Skip to content

Add support for bluetooth pairing in esphome#88603

Merged
bdraco merged 7 commits intodevfrom
esphome_pairing
Mar 7, 2023
Merged

Add support for bluetooth pairing in esphome#88603
bdraco merged 7 commits intodevfrom
esphome_pairing

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 22, 2023

Needs #89262

Proposed change

Bluetooth pairing is now supported by esphome bluetooth proxies

Most of the work for this was done by @jagheterfredrik in esphome/esphome#4475 and esphome/aioesphomeapi#390. Thank you!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown

Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 6, 2023

I think we should do the aioesphomeapi bump in a fresh PR in case we need to backport more fixes to 2023.3.x so whoever is doing a patch release doesn't have to deal with cherry-pick pain if there is a conflict.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 6, 2023

I'll push another branch shortly

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 6, 2023

#89262

@bdraco bdraco added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 6, 2023
@bdraco bdraco marked this pull request as ready for review March 7, 2023 00:18
@bdraco bdraco requested a review from OttoWinter as a code owner March 7, 2023 00:18
@bdraco bdraco merged commit ee89922 into dev Mar 7, 2023
@bdraco bdraco deleted the esphome_pairing branch March 7, 2023 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed integration: esphome noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants