Skip to content

Add air quality support to Open Meteo integration#146204

Closed
freundTech wants to merge 2 commits intohome-assistant:devfrom
freundTech:open-meteo-add-air-quality
Closed

Add air quality support to Open Meteo integration#146204
freundTech wants to merge 2 commits intohome-assistant:devfrom
freundTech:open-meteo-add-air-quality

Conversation

@freundTech
Copy link
Contributor

@freundTech freundTech commented Jun 5, 2025 •
edited
Loading

Proposed change

This PR depends on an accompanying PR in the open_meteo package: frenck/python-open-meteo#1042
To keep this PR small it currently only adds state attributes to the weather entity.

Future PRs can add support for those attributes to the forecast service (though the air quality api only supports hourly data, so we would have to calculate the daily data ourselves based on that) and provide further air quality metrics not supported by weather entities (such as pollen) as sensor entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass (requires manual installation of the open_meteo library with my not yet merged patches)
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all. TODO: open_meteo PR not yet merged
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@freundTech
Add air quality support to Open Meteo integration
7af638b 
This PR depends on an accompanying PR in the open_meteo package: frenck/python-open-meteo#1042
To keep this PR small it currently only adds state attributes to the
weather entity.

Future PRs can add support for those attributes to the forecast service
(though the air quality api only supports hourly data, so we would have
to calculate the daily data ourselfes based on that) and provide further
air quality metrics not supported by weather entities (such as pollen)
as sensor entities.
@freundTech freundTech requested a review from frenck as a code owner June 5, 2025 11:04
@home-assistant
Copy link

home-assistant bot commented Jun 5, 2025

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (open_meteo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of open_meteo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign open_meteo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@freundTech
Add to_dict() method to OpenMeteoData
fec6aa1 
This fixes the missing method error in diagnostics.py
@freundTech freundTech mentioned this pull request Jun 5, 2025
Merged
@freundTech
Copy link
Contributor Author

freundTech commented Jul 4, 2025

Hi @frenck,

I know you're probably very busy with other parts of home-assistant, but you're the only maintainer of both this integration and the library backing it, so I wanted to ask when you might have time to review those changes, as both PRs have now been open for a month without any response.

@joostlek joostlek marked this pull request as draft July 25, 2025 18:14
@joostlek
Copy link
Member

joostlek commented Jul 25, 2025

Putting to draft for now as its waiting on a library bump. I will remind Frenck, can't promise anything.

@frenck
Copy link
Member

frenck commented Sep 17, 2025

I'll pick up upstream. However, please note, you shouldn't be opening pull requests in Home Assistant that are depending on upstream actions. It makes this PR non-actionable. This PR should have been closed. See also our developer documentation for this.

../Frenck

@emontnemery
Copy link
Contributor

emontnemery commented Sep 24, 2025

@freundTech your upstream PR https://github.com/frenck/python-open-meteo/releases/tag/v0.4.0 has been merged, what now needs to happen is:

  • Create a new PR bumping the python-open-meteo version to 0.4.0 and making necessary adjustments (if any are needed)
  • Once the dependency bump PR is merged, this PR can be marked as ready for review

@freundTech
Copy link
Contributor Author

freundTech commented Sep 24, 2025

I'll look into it, but it could take a while. I'm currently on a business trip and my personal laptop stopped charging 2 days ago, so I'll have to wait until I have access to my desktop computer again.

@github-actions
Copy link

github-actions bot commented Nov 23, 2025

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 23, 2025
@github-actions github-actions bot closed this Nov 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@frenck frenck Awaiting requested review from frenck frenck is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@frenck frenck

Labels

cla-signed has-tests integration: open_meteo new-feature Quality Scale: No score stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@freundTech @joostlek @frenck @emontnemery