Omit declined Google Calendar events#128900
Merged
allenporter merged 5 commits intohome-assistant:devfrom Oct 28, 2024
Merged
Conversation
Contributor
|
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
allenporter
requested changes
Oct 21, 2024
Contributor
allenporter
left a comment
There was a problem hiding this comment.
Thank you for sending this, i'm supportive of making this change rather than updating the entity model.
This was referenced Oct 21, 2024
allenporter
requested changes
Oct 28, 2024
Contributor
allenporter
left a comment
There was a problem hiding this comment.
Looking great, just two minor things and I can merge.
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joelhawksley
commented
Oct 28, 2024
allenporter
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Google Calendar events that are declined are now omitted from the calendar.
Proposed change
Remove declined events from Google Calendar.
Type of change
Additional information
@allenporter supports this breaking change: home-assistant/architecture#1137 (reply in thread)
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: