This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Conversation
lucksus
approved these changes
Jul 29, 2020
Collaborator
lucksus
left a comment
There was a problem hiding this comment.
I feel pretty certain, this change is correct - and the old version was not.
| Some(ref updated_entry) => updated_entry.clone(), | ||
| None => header.entry_address().clone(), | ||
| }, | ||
| EntryAspect::Content(_, header) => header.entry_address().clone(), |
Collaborator
There was a problem hiding this comment.
Yes, for a Content aspect, the base (=entry_address) is always exactly the address of that content - even in the case of this entry being an update to another one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
fixed bug in calculating entry address of a Content EntryAspect
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation